Allon Mureinik has uploaded a new change for review. Change subject: core: DbUserCacheManager: add missing modifiers ......................................................................
core: DbUserCacheManager: add missing modifiers Added static and final modifiers where appropriate to utilize Java's memory handling optimizations. Change-Id: Ic4d6d7a2ed75584e326609ae820e054b302748a0 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/12604/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java index d2da67c..6b5146f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java @@ -29,8 +29,8 @@ import org.ovirt.engine.core.utils.timer.SchedulerUtilQuartzImpl; public class DbUserCacheManager { - private static Log log = LogFactory.getLog(DbUserCacheManager.class); - private static DbUserCacheManager _instance = new DbUserCacheManager(); + private static final Log log = LogFactory.getLog(DbUserCacheManager.class); + private static final DbUserCacheManager _instance = new DbUserCacheManager(); private String jobId; private boolean initialized = false; @@ -88,7 +88,7 @@ * @param updatedUsers * list of changed users. */ - private void updateDBUserFromADUser(DbUser dbUser, LdapUser ldapUser, HashSet<Guid> updatedUsers) { + private static void updateDBUserFromADUser(DbUser dbUser, LdapUser ldapUser, HashSet<Guid> updatedUsers) { boolean succeeded = false; if ((ldapUser == null) || (ldapUser.getUserId().equals(Guid.Empty)) @@ -230,7 +230,7 @@ refreshAllUserData(groups); } - private List<LdapGroup> updateGroups() { + private static List<LdapGroup> updateGroups() { List<LdapGroup> groups = DbFacade.getInstance().getAdGroupDao().getAll(); for (LdapGroup group : groups) { /** -- To view, visit http://gerrit.ovirt.org/12604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4d6d7a2ed75584e326609ae820e054b302748a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
