Michael Kublin has posted comments on this change. Change subject: core: Allow force re-election of a specific host as SPM ......................................................................
Patch Set 2: Questions which should be answered in design or mail list: 1. Restart, before, after , in the middle of operation - chosen SPM should be kept or not. 2. Fail to choose SPM - choose another one. Success or failure (Allon's question) 3. I use this button, it means that always I want to choose this host as SPM or once? As for me, such button means that I marked host by highest priority. 4. SPM host priority feature and this feature, sounds very similar 5. Gui: If host which was chosen by me should be marked by some sign or not? 6. REST? Where it is? 7. We have running task - operation failed or we want force to re-elect spm after all task is finished or re-elect now? 8. Implementation: introducing a shared state in memory increasing a complexity of code and can stuck further development like - remove global spm lock. 9. Current implementation has bug - it will make stop to current spm even a user choose it. All answers has influence on implementation. Different answers can cause to implementation look like completely different. This is my reason for -2. -- To view, visit http://gerrit.ovirt.org/12489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife292b85270e6aa8f5bf723ad7d3fa84e325d3d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
