Libor Spevak has posted comments on this change. Change subject: userportal, webadmin: Guaranteed memory not propagated ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java Line 157 Line 158 Line 159 Line 160 Line 161 'Hidden logic' inside bean set/get methods can always cause problems, but I'll test it again, it caused problems during initial code refactoring, maybe it is not current problem. The value is on several places in the code overriden by value based on cluster setting, but I did not test REST API. -- To view, visit http://gerrit.ovirt.org/12413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b82e01d78de1eca585d6e11d326b0f842db52ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Libor Spevak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
