Gilad Chaplik has uploaded a new change for review. Change subject: core: cleanup- removing static from singleton members ......................................................................
core: cleanup- removing static from singleton members QuotaManager is singleton so its members shouldn't be static. Change-Id: I1383d509bab0e99114ad30da264d1ec4e7fd388d Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/12691/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java index 2d0908c..cbf9a03 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java @@ -30,11 +30,11 @@ public class QuotaManager { private static final QuotaManager INSTANCE = new QuotaManager(); - private static final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); - private static final Log log = LogFactory.getLog(QuotaManager.class); - private static HashMap<Guid, Map<Guid, Quota>> storagePoolQuotaMap = new HashMap<Guid, Map<Guid, Quota>>(); + private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + private final Log log = LogFactory.getLog(QuotaManager.class); + private HashMap<Guid, Map<Guid, Quota>> storagePoolQuotaMap = new HashMap<Guid, Map<Guid, Quota>>(); - private static final QuotaManagerAuditLogger quotaManagerAuditLogger = new QuotaManagerAuditLogger(); + private final QuotaManagerAuditLogger quotaManagerAuditLogger = new QuotaManagerAuditLogger(); private final List<QuotaConsumptionParameter> corruptedParameters = new ArrayList<QuotaConsumptionParameter>(); private final Map<Integer, Integer> nonCountableQutoaVmStatusesMap = new HashMap<Integer, Integer>(); -- To view, visit http://gerrit.ovirt.org/12691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1383d509bab0e99114ad30da264d1ec4e7fd388d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
