Allon Mureinik has posted comments on this change.

Change subject: core, restapi: Remove double ReapedMaps
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReapedMapTest.java
Line 142: 
Line 143:             @Override
Line 144:             public Reference<Integer> answer(InvocationOnMock 
invocation) throws Throwable {
Line 145:                 if (times == gcAfter) {
Line 146:                     ++times;
Not a fan of either.
Although the ternary can actually be OK on second thought.
Will redo
Line 147:                     return ref;
Line 148:                 }
Line 149: 
Line 150:                 ++times;


--
To view, visit http://gerrit.ovirt.org/12722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I924355a495945a063b8e15f233188fc236df2432
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to