Laszlo Hornyak has posted comments on this change. Change subject: engine: remove obfustration from local var ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java Line 244 Line 245 Line 246 Line 247 Line 248 nice :-) If you want the password, it is in cleartext in the memory, you do not have to to hardware hacking or break the JVM, you only have to get it from the configuration bean, it is stored there as a string. So this is the reason, the local variable obfuscator is really redundant here. -- To view, visit http://gerrit.ovirt.org/12720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a631bf8974bbebe2d98d47e5f58c902af3149b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
