[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix findbugs warnings in Volume tab

[kmayilsa]

Kanagaraj M has uploaded a new change for review.

Change subject: webadmin: Fix findbugs warnings in Volume tab
......................................................................

webadmin: Fix findbugs warnings in Volume tab

Using StringBuilder instead of String when doing
String concatenation in a loop.

Change-Id: I4153b3da606e1b579d3126526319bc0e5e09a46e
Signed-off-by: Kanagaraj M <kmayi...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/12753/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
index 48e70e4..e88d353 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
@@ -83,26 +83,26 @@
                 new TextColumnWithTooltip<GlusterVolumeEntity>() {
                     @Override
                     public String getValue(GlusterVolumeEntity object) {
-                        String transportTypes = "";//$NON-NLS-1$
+                        StringBuilder transportTypes = new StringBuilder();
                         Iterator<TransportType> iterator = 
object.getTransportTypes().iterator();
                         while (iterator.hasNext())
                         {
                             TransportType transportType = iterator.next();
                             if 
(transportTypeTranslator.containsKey(transportType))
                             {
-                                transportTypes += 
transportTypeTranslator.get(transportType);
+                                
transportTypes.append(transportTypeTranslator.get(transportType));
                             }
                             else
                             {
-                                transportTypes += transportType.toString();
+                                
transportTypes.append(transportType.toString());
                             }
 
                             if (iterator.hasNext())
                             {
-                                transportTypes += ", ";//$NON-NLS-1$
+                                transportTypes.append(", "); //$NON-NLS-1$
                             }
                         }
-                        return transportTypes;
+                        return transportTypes.toString();
                     }
 
                 };


--
To view, visit http://gerrit.ovirt.org/12753
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4153b3da606e1b579d3126526319bc0e5e09a46e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches