Allon Mureinik has posted comments on this change.
Change subject: engine: avoid passing userId in User queries
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsAndVmPoolsQuery.java
Line 26: }
Line 27: if (isSucceeded) {
Line 28: queryResult =
Line 29:
Backend.getInstance().runInternalQuery(VdcQueryType.GetAllVmPoolsAttachedToUser,
Line 30: new VdcQueryParametersBase());
getUser(), which the.GetAllVmPoolsAttachedToUserQuery should used, is based on
the sessionId passed on the parameters.
You should pass getParameters() here, not create a new object.
Line 31: if (queryResult != null && queryResult.getSucceeded()) {
Line 32: retValList.addAll((List<VmPool>)
queryResult.getReturnValue());
Line 33: } else {
Line 34: isSucceeded = false;
--
To view, visit http://gerrit.ovirt.org/12458
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06bec1770adbc6dce07baae8e5fc7f163b39fc52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
