Eli Mesika has posted comments on this change.
Change subject: engine: watchdog support [wip]
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 1015: <xs:complexType name="WatchDogType">
Line 1016: <xs:sequence>
Line 1017: <xs:element name="model" type="xs:string" minOccurs="1"
maxOccurs="1"/>
Line 1018: <xs:element name="action" type="xs:string" minOccurs="1"
maxOccurs="1"/>
Line 1019: </xs:sequence>
please remove TABs
Line 1020: </xs:complexType>
Line 1021:
Line 1022: <xs:complexType name="MemoryPolicy">
Line 1023: <xs:sequence>
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java
Line 130: }
Line 131: if (model.isSetTunnelMigration()) {
Line 132: entity.setTunnelMigration(model.isTunnelMigration());
Line 133: }
Line 134: if(model.getWatchdog() != null) {
please use isSetWatchdog
Line 135: entity.setWatchdogAction(model.getWatchdog().getAction());
Line 136: entity.setWatchdogModel(model.getWatchdog().getModel());
Line 137: }
Line 138: return entity;
Line 239: }
Line 240: if (model.isSetTunnelMigration()) {
Line 241: staticVm.setTunnelMigration(model.isTunnelMigration());
Line 242: }
Line 243: if(model.getWatchdog() != null) {
same (see above)
Line 244:
staticVm.setWatchdogAction(model.getWatchdog().getAction());
Line 245: staticVm.setWatchdogModel(model.getWatchdog().getModel());
Line 246: }
Line 247: return staticVm;
Line 326: model.setUsb(usb);
Line 327: }
Line 328:
model.setTimezone(TimeZoneMapping.getJava(entity.getTimeZone()));
Line 329: model.setTunnelMigration(entity.getTunnelMigration());
Line 330: if(entity.getWatchdogModel() != null) {
same
Line 331: model.setWatchdog(new WatchDogType());
Line 332: model.getWatchdog().setAction(entity.getWatchdogAction());
Line 333: model.getWatchdog().setModel(entity.getWatchdogModel());
Line 334: }
--
To view, visit http://gerrit.ovirt.org/12419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5c36995dafcef6b3ad45a9e0ca8b0471324b70
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
