Vered Volansky has posted comments on this change.
Change subject: core: Unfilter ImagesHandler.PerformImagesChecks
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
I just want an answer to my question, since it would probably cause a follow-up.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 80: */
Line 81: private List<DiskImage> getDisksList() {
Line 82: if (selectedActiveDisks == null) {
Line 83: selectedActiveDisks =
ImagesHandler.filterImageDisks(DbFacade.getInstance().getDiskDao().getAllForVm(getVmId()),
Line 84: true,
Why the change from false to true?
Line 85: true);
Line 86: }
Line 87: return selectedActiveDisks;
Line 88: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
Line 212: }
Line 213:
Line 214: updateVmDisksFromDb();
Line 215: List<DiskImage> diskImages =
Line 216:
ImagesHandler.filterImageDisks(getVm().getDiskMap().values(), true, true);
As before - Justify the change of boolean value
Line 217: if (!diskImages.isEmpty()) {
Line 218: Set<Guid> storageIds =
ImagesHandler.getAllStorageIdsForImageIds(diskImages);
Line 219: MultipleStorageDomainsValidator storageValidator =
Line 220: new
MultipleStorageDomainsValidator(getVm().getStoragePoolId(), storageIds);
....................................................
Commit Message
Line 6:
Line 7: core: Unfilter ImagesHandler.PerformImagesChecks
Line 8:
Line 9: Before this patch, ImagesHandler.PerformImagesChecks received a
Line 10: collection of Disks, and filtered them so only DiskImages which aren't
/s/which/that
Line 11: sharable were evaluated.
Line 12:
Line 13: This patch removes the filtering from this methods, and makes it the
Line 14: responsibility of the calling method to perform any required filtering.
--
To view, visit http://gerrit.ovirt.org/12321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc93d1bb72daed053f0f37ae3c3f12efef915669
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
