Michael Kublin has uploaded a new change for review. Change subject: engine: IrsBroker - code clean up ......................................................................
engine: IrsBroker - code clean up Code is cleaned. Change is obvious. Motivation: I was bored... Change-Id: I3818a9ec43df939f293630853a99348811aa7127 Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/12814/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java index 9dc894f..40ed274 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java @@ -706,7 +706,7 @@ RefObject<SpmStatusResult> spmStatus, StoragePoolStatus prevStatus) { String returnValue = null; if (spmStatus.argvalue == null || spmStatus.argvalue.getSpmStatus() != SpmStatus.SPM) { - movePoolToProblematicInDB(storagePool, true); + movePoolToProblematicInDB(storagePool); selectedVds.argvalue = null; log.infoFormat( @@ -766,17 +766,15 @@ } } - private void movePoolToProblematicInDB(storage_pool storagePool, boolean resetSpmInDB) { + private void movePoolToProblematicInDB(storage_pool storagePool) { ResourceManager .getInstance() .getEventListener() .storagePoolStatusChange(storagePool.getId(), StoragePoolStatus.Problematic, AuditLogType.SYSTEM_CHANGE_STORAGE_POOL_STATUS_PROBLEMATIC, VdcBllErrors.ENGINE); - if (resetSpmInDB) { - storagePool.setspm_vds_id(null); - DbFacade.getInstance().getStoragePoolDao().update(storagePool); - } + storagePool.setspm_vds_id(null); + DbFacade.getInstance().getStoragePoolDao().update(storagePool); } private SpmStatusResult handleSpmStatusResult(Guid curVdsId, -- To view, visit http://gerrit.ovirt.org/12814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3818a9ec43df939f293630853a99348811aa7127 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
