Moti Asayag has posted comments on this change.
Change subject: tools: don't rely on Connection.isValid()
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java
Line 116: ResultSet rs = null;
Line 117: try {
Line 118: statement = connection.createStatement();
Line 119: rs = statement.executeQuery("select null");
Line 120: rs.next();
is this statement is required ?
Line 121: }
Line 122: finally {
Line 123: if (rs != null) {
Line 124: rs.close();
--
To view, visit http://gerrit.ovirt.org/12812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f1fe6a9981c6fe8764a803eda4de5d51cc2b6e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
