Eli Mesika has uploaded a new change for review. Change subject: core: Authentication error messages on the engine. ......................................................................
core: Authentication error messages on the engine. Authentication error messages on the engine.log should specify the user used Adding the user name used in all DirectorySearcher logged errors. Change-Id: Ia29947906a5e5aa905324fe90793ba14d86faf60 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/12828/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java index faf5f13..fd85d66 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java @@ -69,7 +69,7 @@ final Domain domain = getDomainObject(domainName); if (domain == null) { - log.errorFormat("Error in finding LDAP servers for domain {0}", domainName); + log.errorFormat("Error in finding LDAP servers for domain {0} using user {1}", domainName, ldapCredentials.getUserName()); return null; } @@ -121,12 +121,14 @@ Exception translatedException = handlingResponse.getTranslatedException(); setException(translatedException); LdapServersOrderingAlgorithmFactory.getInstance().getOrderingAlgorithm(handlingResponse.getOrderingAlgorithm()).reorder(ldapURI, modifiedLdapServersURIs); - log.errorFormat("Failed ldap search server {0} due to {1}. We {2} try the next server", + log.errorFormat("Failed ldap search server {0} using user {1} due to {2}. We {3} try the next server", ldapURI, + ldapCredentials.getUserName(), LdapBrokerUtils.getFriendlyExceptionMessage(translatedException), handlingResponse.isTryNextServer() ? "should" : "should not"); - log.debugFormat("Failed ldap search server {0} due to {1}. We {2} try the next server", + log.debugFormat("Failed ldap search server {0} using user {1} due to {2}. We {3} try the next server", ldapURI, + ldapCredentials.getUserName(), translatedException, handlingResponse.isTryNextServer() ? "should" : "should not"); if (!handlingResponse.isTryNextServer()) { -- To view, visit http://gerrit.ovirt.org/12828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia29947906a5e5aa905324fe90793ba14d86faf60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
