Allon Mureinik has uploaded a new change for review. Change subject: core: UpdateVmDiskCommand - synthetic access warn ......................................................................
core: UpdateVmDiskCommand - synthetic access warn Changed modifiers from private to protected to avoid synthetic access warnings. This may also result in a slight performance improvements, but I doubt it would be noticeable. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: I07ed8b37f4c22807b8981959b7b03d7baa19de68 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/12885/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java index 1ba335b..ec06a04 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java @@ -19,10 +19,10 @@ import org.ovirt.engine.core.common.businessentities.DiskImage; import org.ovirt.engine.core.common.businessentities.Snapshot.SnapshotStatus; import org.ovirt.engine.core.common.businessentities.Snapshot.SnapshotType; -import org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface; import org.ovirt.engine.core.common.businessentities.VM; import org.ovirt.engine.core.common.businessentities.VMStatus; import org.ovirt.engine.core.common.businessentities.VmDeviceId; +import org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface; import org.ovirt.engine.core.common.utils.Pair; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.dal.VdcBllMessages; @@ -38,8 +38,8 @@ private static final long serialVersionUID = 5915267156998835363L; private List<PermissionSubject> listPermissionSubjects; - private final Disk oldDisk; - private final Disk newDisk; + protected final Disk oldDisk; + protected final Disk newDisk; private Map<String, Pair<String, String>> sharedLockMap; private Map<String, Pair<String, String>> exclusiveLockMap; @@ -113,8 +113,7 @@ allVmDisks.removeAll(LinqUtils.filter(allVmDisks, new Predicate<Disk>() { @Override public boolean eval(Disk o) { - return o.getId().equals( - oldDisk.getId()); + return o.getId().equals(oldDisk.getId()); } })); allVmDisks.add(newDisk); @@ -289,7 +288,7 @@ newDisk instanceof DiskImage && DiskStorageType.IMAGE == oldDisk.getDiskStorageType(); } - private Guid getQuotaId() { + protected Guid getQuotaId() { if (newDisk != null && isQuotaValidationNeeded()) { return ((DiskImage) newDisk).getQuotaId(); } -- To view, visit http://gerrit.ovirt.org/12885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I07ed8b37f4c22807b8981959b7b03d7baa19de68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
