Omer Frenkel has posted comments on this change.
Change subject: webadmin: Show migrating VM on destination host
......................................................................
Patch Set 1: (2 inline comments)
looks ok, minor comments inside,
@michal - not sure i understand your question, when vm is in paused then it
should only be visible on the host it is running on, the run_on_vds, basically
migrating_to_vds field should be cleared, but not sure.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
Line 122: .addValue("vds_id", id));
Line 123: }
Line 124:
Line 125: @Override
Line 126: public List<VM> getAllRunningOnOrMigratingToVds(Guid id) {
please add DAO test
Line 127: return
getCallsHandler().executeReadList("GetVmsRunningOnOrMigratingToVds",
Line 128: VMRowMapper.instance,
Line 129: getCustomMapSqlParameterSource()
Line 130: .addValue("vds_id", id));
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVmListModel.java
Line 45: @Override
Line 46: public void Search()
Line 47: {
Line 48: // Override standard search query mechanism.
Line 49: // Dduring the migration, the host should be visible on source
host (Migrating From), and also
typo: 1. During 2. "the host should.." -> "the vm should.."
Line 50: // on destination host (Migrating To)
Line 51: if (getEntity() != null)
Line 52: {
Line 53: AsyncDataProvider.GetVmsRunningOnOrMigratingToVds(new
AsyncQuery(this, new INewAsyncCallback() {
--
To view, visit http://gerrit.ovirt.org/12878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae8228e4a6e9e7e91b8224f0ef2764c5e4e25cfa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
