Liron Ar has posted comments on this change.
Change subject: core: UpdateVmDisk: unify other disk retrieval
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 40: private static final long serialVersionUID = 5915267156998835363L;
Line 41: private List<PermissionSubject> listPermissionSubjects;
Line 42: protected final Disk oldDisk;
Line 43: protected final Disk newDisk;
Line 44: private List<Disk> otherVmDisks;
i think that this better not be a member.
Line 45: private Map<String, Pair<String, String>> sharedLockMap;
Line 46: private Map<String, Pair<String, String>> exclusiveLockMap;
Line 47:
Line 48: public UpdateVmDiskCommand(T parameters) {
Line 146: @Override
Line 147: public boolean eval(Disk o) {
Line 148: return o.getId().equals(oldDisk.getId());
Line 149: }
Line 150: }));
It will be better to just add if the id is different than 'oldDisk'
Line 151: }
Line 152: return otherVmDisks;
Line 153: }
Line 154:
--
To view, visit http://gerrit.ovirt.org/12887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31bcb767bf86d6f16116cfa06a710bb0488b087f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
