Liron Ar has posted comments on this change.

Change subject: core: Cleanup AttachDiskToVmCommand.canDoAction()
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 28: import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
Line 29: import org.ovirt.engine.core.compat.Guid;
Line 30: import org.ovirt.engine.core.dal.VdcBllMessages;
Line 31: 
Line 32: @LockIdNameAttribute
is it related to this patch?
Line 33: public class AttachDiskToVmCommand<T extends 
AttachDettachVmDiskParameters> extends AbstractDiskVmCommand<T> {
Line 34: 
Line 35:     private static final long serialVersionUID = -1686587389737849288L;
Line 36:     private List<PermissionSubject> permsList = null;


--
To view, visit http://gerrit.ovirt.org/12894
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cb0cc87c82387e8b1dcac0142f3625a4cc232d2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to