Liron Ar has posted comments on this change.
Change subject: core: UpdateVmCommand: Shared disk boot status
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 40: private static final long serialVersionUID = 5915267156998835363L;
Line 41: private List<PermissionSubject> listPermissionSubjects;
Line 42: protected final Disk oldDisk;
Line 43: protected final Disk newDisk;
Line 44: private Map<Guid, List<Disk>> otherVmDisks = new HashMap<Guid,
List<Disk>>();
i understand, but as this is used only in one method (and one called within)
i'd not make it a member..but i don't mind, fine by me.
Line 45: private Map<String, Pair<String, String>> sharedLockMap;
Line 46: private Map<String, Pair<String, String>> exclusiveLockMap;
Line 47:
Line 48: public UpdateVmDiskCommand(T parameters) {
--
To view, visit http://gerrit.ovirt.org/12889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a9d2e8800b9bf693fc55d8a627e0725277985ac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
