Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fix Unlimited quota is counted as -1
......................................................................
Patch Set 1: (1 inline comment)
currently the 'used' is missing in the grid. I would add it in all cases, but
at least in unlimited (currently there are 2 columns marked as unlimited
(duplicate data?), and there is no way to retrieve the 'used' resources count).
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java
Line 68: allocated =
object.getGlobalQuotaVdsGroup().getMemSizeMB();
Line 69: used =
object.getGlobalQuotaVdsGroup().getMemSizeMBUsage();
Line 70: } else {
Line 71: for (QuotaVdsGroup quotaVdsGroup :
object.getQuotaVdsGroups()) {
Line 72: if
(!QuotaVdsGroup.UNLIMITED_MEM.equals(quotaVdsGroup.getMemSizeMB())) {
Consider refactoring primitive wrapper classes to primitive types (it's sth I
wanted to do long ago). iirc, quota BEs has a lot of those.
Line 73: allocated += quotaVdsGroup.getMemSizeMB();
Line 74: used += quotaVdsGroup.getMemSizeMBUsage();
Line 75: }
Line 76: }
--
To view, visit http://gerrit.ovirt.org/12908
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f49bfe3576cecccf80e9ad2105506e3eb267d83
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
