Allon Mureinik has posted comments on this change.

Change subject: core: Remove FileUtil unneeded methods
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
Line 1082:             } catch (Exception e) {
Line 1083:                 // Ignore
Line 1084:             }
Line 1085:         }
Line 1086:     }
Consider moving this to a more general-purpose utility, looks useful.
Line 1087: 
Line 1088:     private static void copyFile(String srcFilePath, String 
dstFilePath) throws IOException {
Line 1089:         InputStream in = new FileInputStream(srcFilePath);
Line 1090:         OutputStream out = new FileOutputStream(dstFilePath);


--
To view, visit http://gerrit.ovirt.org/12425
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9aac66024e244bdbff52c3b7b86948a236ad0af
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to