Tal Nisan has posted comments on this change. Change subject: core: Cleanup AbstractDisk.isDiskCanBeAddedToVm ......................................................................
Patch Set 4: (1 inline comment) .................................................... Commit Message Line 5: CommitDate: 2013-03-10 15:39:24 +0200 Line 6: Line 7: core: Cleanup AbstractDisk.isDiskCanBeAddedToVm Line 8: Line 9: Extracted the updateDisksFromDb() method form isDiskCanBeAddedToVm() s/form/from Line 10: method for better encapsulation, and employed the early-return idiom for Line 11: better readability. Line 12: Line 13: Relates-To: https://bugzilla.redhat.com/854964 -- To view, visit http://gerrit.ovirt.org/12896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e5aafada5012ae06c7105bafa5538026e42b1b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
