Muli Salem has posted comments on this change.

Change subject: engine: Allow Import/Snapshot Duplicate MAC Address
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 572:     private static <T extends VmBase> void updateVmDevice(T entity,
Line 573:             VmDevice vmDevice,
Line 574:             Guid deviceId,
Line 575:             List<VmDevice> vmDeviceToUpdate,
Line 576:             VmNetworkInterface iface) {
Done
Line 577:         // update device information only if ovf support devices - 
from 3.1
Line 578:         Version ovfVer = new Version(entity.getOvfVersion());
Line 579:         if (!VmDeviceCommonUtils.isOldClusterVersion(ovfVer)) {
Line 580:             VmDevice exportedDevice = 
entity.getManagedDeviceMap().get(deviceId);


Line 623:                     addManagedDevice(new VmDeviceId(deviceId, id),
Line 624:                             VmDeviceType.INTERFACE,
Line 625:                             VmDeviceType.BRIDGE,
Line 626:                             null,
Line 627:                             true,
Done
Line 628:                             false,
Line 629:                             getAddress(entity, id));
Line 630:             updateVmDevice(entity, vmDevice, deviceId, 
vmDeviceToUpdate, iface);
Line 631:         }


--
To view, visit http://gerrit.ovirt.org/12241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I269157b37426942331002c33a22fa354ba0cf39e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to