Vered Volansky has uploaded a new change for review. Change subject: core: fix broken broken statistics updates ......................................................................
core: fix broken broken statistics updates Change Id Ie8f39b5cdc3771f438f9c61897cb0242e8bb6c90 inserted a regression and broke statistics updates. Column update_date was added to several statistics tables, while update statements referred to it as _update_date (leading _ ). This patch fixes the references to this column to also be update_date. Change-Id: Ic6fb9b660f4458bd30077caaa0f73f1df9ca219d Signed-off-by: Vered Volansky <[email protected]> --- M backend/manager/dbscripts/disk_image_dynamic_sp.sql M backend/manager/dbscripts/network_sp.sql M backend/manager/dbscripts/storages_san_sp.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/dbscripts/vms_sp.sql 5 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/12953/1 diff --git a/backend/manager/dbscripts/disk_image_dynamic_sp.sql b/backend/manager/dbscripts/disk_image_dynamic_sp.sql index bb2e1f0..66aaf1f 100644 --- a/backend/manager/dbscripts/disk_image_dynamic_sp.sql +++ b/backend/manager/dbscripts/disk_image_dynamic_sp.sql @@ -40,7 +40,7 @@ AS $procedure$ BEGIN UPDATE disk_image_dynamic - SET read_rate = v_read_rate,write_rate = v_write_rate,actual_size = v_actual_size,read_latency_seconds = v_read_latency_seconds,write_latency_seconds = v_write_latency_seconds,flush_latency_seconds = v_flush_latency_seconds, _update_date = LOCALTIMESTAMP + SET read_rate = v_read_rate,write_rate = v_write_rate,actual_size = v_actual_size,read_latency_seconds = v_read_latency_seconds,write_latency_seconds = v_write_latency_seconds,flush_latency_seconds = v_flush_latency_seconds, update_date = LOCALTIMESTAMP WHERE image_id = v_image_id; END; $procedure$ LANGUAGE plpgsql; diff --git a/backend/manager/dbscripts/network_sp.sql b/backend/manager/dbscripts/network_sp.sql index 864073f..d91ce42 100644 --- a/backend/manager/dbscripts/network_sp.sql +++ b/backend/manager/dbscripts/network_sp.sql @@ -571,7 +571,7 @@ BEGIN UPDATE vm_interface_statistics SET rx_drop = v_rx_drop,rx_rate = v_rx_rate,tx_drop = v_tx_drop,tx_rate = v_tx_rate, - vm_id = v_vm_id,iface_status = v_iface_status, _update_date = LOCALTIMESTAMP + vm_id = v_vm_id,iface_status = v_iface_status, update_date = LOCALTIMESTAMP WHERE id = v_id; END; $procedure$ LANGUAGE plpgsql; @@ -679,7 +679,7 @@ BEGIN UPDATE vds_interface_statistics SET rx_drop = v_rx_drop,rx_rate = v_rx_rate,tx_drop = v_tx_drop,tx_rate = v_tx_rate, - vds_id = v_vds_id,iface_status = v_iface_status, _update_date = LOCALTIMESTAMP + vds_id = v_vds_id,iface_status = v_iface_status, update_date = LOCALTIMESTAMP WHERE id = v_id; END; $procedure$ LANGUAGE plpgsql; diff --git a/backend/manager/dbscripts/storages_san_sp.sql b/backend/manager/dbscripts/storages_san_sp.sql index f36572a..29c7eec 100644 --- a/backend/manager/dbscripts/storages_san_sp.sql +++ b/backend/manager/dbscripts/storages_san_sp.sql @@ -149,7 +149,7 @@ AS $procedure$ BEGIN UPDATE storage_domain_dynamic - SET available_disk_size = v_available_disk_size,used_disk_size = v_used_disk_size, _update_date = LOCALTIMESTAMP + SET available_disk_size = v_available_disk_size,used_disk_size = v_used_disk_size, update_date = LOCALTIMESTAMP WHERE id = v_id; END; $procedure$ LANGUAGE plpgsql; diff --git a/backend/manager/dbscripts/vds_sp.sql b/backend/manager/dbscripts/vds_sp.sql index 0e73f21..282227b 100644 --- a/backend/manager/dbscripts/vds_sp.sql +++ b/backend/manager/dbscripts/vds_sp.sql @@ -68,7 +68,7 @@ usage_network_percent = v_usage_network_percent, mem_available = v_mem_available,mem_shared = v_mem_shared, swap_free = v_swap_free,swap_total = v_swap_total,ksm_cpu_percent = v_ksm_cpu_percent, - ksm_pages = v_ksm_pages,ksm_state = v_ksm_state, _update_date = LOCALTIMESTAMP + ksm_pages = v_ksm_pages,ksm_state = v_ksm_state, update_date = LOCALTIMESTAMP WHERE vds_id = v_vds_id; END; diff --git a/backend/manager/dbscripts/vms_sp.sql b/backend/manager/dbscripts/vms_sp.sql index a99a501..a425a93 100644 --- a/backend/manager/dbscripts/vms_sp.sql +++ b/backend/manager/dbscripts/vms_sp.sql @@ -157,7 +157,7 @@ UPDATE vm_statistics SET cpu_sys = v_cpu_sys,cpu_user = v_cpu_user,elapsed_time = v_elapsed_time, usage_cpu_percent = v_usage_cpu_percent,usage_mem_percent = v_usage_mem_percent, - usage_network_percent = v_usage_network_percent,disks_usage = v_disks_usage, _update_date = LOCALTIMESTAMP + usage_network_percent = v_usage_network_percent,disks_usage = v_disks_usage, update_date = LOCALTIMESTAMP WHERE vm_guid = v_vm_guid; END; $procedure$ LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/12953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6fb9b660f4458bd30077caaa0f73f1df9ca219d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
