Daniel Erez has uploaded a new change for review. Change subject: webadmin: Make Template dialog - style modifications ......................................................................
webadmin: Make Template dialog - style modifications Make Template dialog: * Fixed TemplatePublicEditor overlapping disk list. * Moved messagePanel into a ScrollPanel (for handling long messages). Change-Id: I92415bc120b10a92712d554d2697a3831552c7b3 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 3 files changed, 11 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/12955/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml index 53ce9a6..a0fdf14 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml @@ -5,27 +5,18 @@ xmlns:w="urn:import:org.ovirt.engine.ui.common.widget.uicommon.storage"> <ui:style type="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmMakeTemplatePopupWidget.WidgetStyle"> - .content { - - } - .editorLabel { width: 360px; } .messagePanel { color: #CD2127; - position: absolute; - bottom: 15px; - } - - .isTemplatePublicEditor { - position: absolute; - bottom: 80px; + height: 65px; } .disksAllocationPanel { width: 100%; + height: 190px; float: right; } @@ -42,12 +33,13 @@ <e:ListModelListBoxEditor ui:field="clusterEditor" /> <e:ListModelListBoxEditor ui:field="quotaEditor" /> <g:Label ui:field="disksAllocationLabel" addStyleNames="{style.disksAllocationLabel}" /> - <w:DisksAllocationView ui:field="disksAllocationView" listHeight="170px" listWidth="475px" addStyleNames="{style.disksAllocationPanel}" /> - <g:VerticalPanel> - <e:EntityModelCheckBoxEditor ui:field="isTemplatePublicEditor" addStyleNames="{style.isTemplatePublicEditor}" /> - <g:FlowPanel ui:field="messagePanel" addStyleNames="{style.messagePanel}"> - </g:FlowPanel> - </g:VerticalPanel> + <w:DisksAllocationView ui:field="disksAllocationView" listHeight="155px" listWidth="445px" addStyleNames="{style.disksAllocationPanel}" /> + <g:FlowPanel> + <e:EntityModelCheckBoxEditor ui:field="isTemplatePublicEditor" /> + <g:ScrollPanel> + <g:FlowPanel ui:field="messagePanel" addStyleNames="{style.messagePanel}" /> + </g:ScrollPanel> + </g:FlowPanel> </g:FlowPanel> </ui:UiBinder> diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java index 90548b5..c239f49 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java @@ -20,7 +20,7 @@ @Inject public VmMakeTemplatePopupView(EventBus eventBus, ApplicationResources resources, ApplicationConstants constants) { - super(eventBus, resources, new VmMakeTemplatePopupWidget(constants), "490px", "490px"); //$NON-NLS-1$ //$NON-NLS-2$ + super(eventBus, resources, new VmMakeTemplatePopupWidget(constants), "460px", "490px"); //$NON-NLS-1$ //$NON-NLS-2$ ViewIdHandler.idHandler.generateAndSetIds(this); } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java index b4ca68f..1d78b99 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java @@ -20,7 +20,7 @@ @Inject public VmMakeTemplatePopupView(EventBus eventBus, ApplicationResources resources, ApplicationConstants constants) { - super(eventBus, resources, new VmMakeTemplatePopupWidget(constants), "490px", "490px"); //$NON-NLS-1$ //$NON-NLS-2$ + super(eventBus, resources, new VmMakeTemplatePopupWidget(constants), "460px", "490px"); //$NON-NLS-1$ //$NON-NLS-2$ ViewIdHandler.idHandler.generateAndSetIds(this); } -- To view, visit http://gerrit.ovirt.org/12955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I92415bc120b10a92712d554d2697a3831552c7b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
