Alon Bar-Lev has posted comments on this change.
Change subject: core: introduce osinfo service instead of Config values
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/LibosinfoClient.java
Line 86:
Line 87: String options = "-Djava.rmi.server.hostname=localhost";
Line 88: String mainClassName =
"org.ovirt.engine.core.osinfo.server.LibosinfoServer";
Line 89:
Line 90: builder.command(java, "-cp", classpath, options,
mainClassName);
Not just JVM, any long running service, because:
1. This service is independent service, and should be managed as-its own
(stop/start).
2. This service should be managed, its entire lifecycle, so we need a complete
mechanism to monitor its existence, avoid it being zombie, stop when we restart.
3. Resource leak of file descriptors and other is a great potential here.
4. ulimit of time process may be up is not guarantee to be infinite.
5. As jboss may be a good j2ee application server, it is far from being a good
native scheduler.
6. We may (in future) donate this code as standalone code to libosinfo, as it
has nothing to do with engine.
7. we may (in future) use HTTP and not RMI and maybe even use a service
remotely on the Internet or remote provider.
In short we should decoupled the services as much as we can, systemd provides
dependency layout, reexecution and monitoring, there is no reason to avoid
using basic service to manage long running services.
Yes, we have this in the certificate signature, and this exactly the reason why
it is hard to replace the implementation with 3rd party CA, or having to
monitor and kill the process after timeout, resulting in potential zombies and
leaks.
Line 91: return builder;
Line 92: }
Line 93:
Line 94: private ProcessBuilder buildShellProcessCmd() {
--
To view, visit http://gerrit.ovirt.org/12936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd75679a1a1af5d5a0925e181b5dfd6e87574a75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
