Michael Kublin has uploaded a new change for review.

Change subject: engine: Fixing small bug in canDoaction() of RemoveVdsCommand
......................................................................

engine: Fixing small bug in canDoaction() of RemoveVdsCommand

Missing condition in if, change is obvious

Change-Id: I7f342d15a7c9f2d6e6ed8de05ab87b839600c56b
Signed-off-by: Michael Kublin <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/12998/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
index 8f2bf49..9b25c53 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
@@ -82,7 +82,7 @@
         }
 
         // Perform volume bricks on server and up server null check only when 
force action is false
-        if (isGlusterEnabled() && !getParameters().isForceAction()) {
+        if (returnValue && isGlusterEnabled() && 
!getParameters().isForceAction()) {
             if (hasVolumeBricksOnServer()) {
                 
addCanDoActionMessage(VdcBllMessages.VDS_CANNOT_REMOVE_HOST_HAVING_GLUSTER_VOLUME);
                 returnValue = false;


--
To view, visit http://gerrit.ovirt.org/12998
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f342d15a7c9f2d6e6ed8de05ab87b839600c56b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to