Vojtech Szocs has posted comments on this change. Change subject: webadmin: About dialog - remove redundant code ......................................................................
Patch Set 1: Looks good to me, approved Nice patch! Maybe we could go even further: * in CommonModel and LoginModel, remove About() method + AboutCommand, since no UI code binds to AboutCommand * remove AboutModel class entirely -- To view, visit http://gerrit.ovirt.org/12956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e99e5b48866be7c40d5085195eea3298de36aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
