Vojtech Szocs has posted comments on this change. Change subject: webadmin: moving the Login popup to center on Browser resize ......................................................................
Patch Set 1: Hi Kanagaraj, I have some comments: * we could move Window resize handler into AbstractLoginPopupView constructor, so that both WebAdmin and UserPortal have this behavior * besides login popup, we should also consider this behavior for all dialogs (AbstractPopupView) * handling Window resize events in JavaScript can be overkill in older browsers, maybe we should try to invest some time to find CSS-based (faster) solution What do you think? -- To view, visit http://gerrit.ovirt.org/12468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe16a88a094ad5fa4a5cf81892183f44c1ff3600 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
