Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use conf.d notation in shell utilities
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File backend/manager/tools/src/main/shell/engine-prolog.sh.in
Line 14: export ENGINE_VARS
Line 15:
Line 16: for f in "${ENGINE_DEFAULTS}" "${ENGINE_VARS}" $(find
"${ENGINE_VARS}.d" -name '*.conf' | sort); do
Line 17: [ -r "${f}" ] && . "${f}"
Line 18: done
Only the defaults is mandatory, we will not make use of the conf file, only the
conf.d in future, so I don't mind a message for the defaults if this what you
want, but the other is wrong.
Line 19:
Line 20: # Clean the class path:
Line 21: CLASSPATH=""
Line 22: export CLASSPATH
--
To view, visit http://gerrit.ovirt.org/12677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb03986e385cf786fa191095ad7fcc443d2f1199
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
