Michael Kublin has uploaded a new change for review. Change subject: engine: Removing useless null check ......................................................................
engine: Removing useless null check The following check is useless, but causing for failure of find bugs Change-Id: Ia0e5ba1b9bc0484edafe9a5a88f6f5b599e3202f Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/13039/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java index 53c7fba..6d0aaf7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java @@ -329,8 +329,7 @@ VdcReturnValueBase returnValue = null; // Evaluate and set the correlationId on the parameters, fails on invalid correlation id - boolean hasCorrelationId = - parameters == null ? false : StringUtils.isNotEmpty(parameters.getCorrelationId()); + boolean hasCorrelationId = StringUtils.isNotEmpty(parameters.getCorrelationId()); returnValue = ExecutionHandler.evaluateCorrelationId(parameters); if (returnValue != null) { log.warnFormat("CanDoAction of action {0} failed. Reasons: {1}", actionType, -- To view, visit http://gerrit.ovirt.org/13039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0e5ba1b9bc0484edafe9a5a88f6f5b599e3202f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
