Alon Bar-Lev has posted comments on this change.
Change subject: tools: Don't use console for debug log
......................................................................
Patch Set 4: (1 inline comment)
Can you please explain why is this Console class needed? I truly don't
understand the difference betweein using it and simply using
System.out/System.in for standard io and Console for reading passwords and
prompt for user interaction.
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/Console.java
Line 126: /**
Line 127: * Read a line from the standard input.
Line 128: */
Line 129: public String readLine() {
Line 130: String line = System.console().readLine();
Are you sure this is from stdin? I think this is from terminal... check echo
"alon" | java xxx, and see if it reads the "alon".
Line 131: log.info("Read from stdin \"" + line + "\".");
Line 132: return line;
Line 133: }
Line 134:
--
To view, visit http://gerrit.ovirt.org/12987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I556e20f6333e22faeb7d212767ebefb99edce54e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
