Allon Mureinik has posted comments on this change.
Change subject: core: Change to use generic "name exists" message
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddBookmarkCommand.java
Line 15: if (DbFacade.getInstance().getBookmarkDao()
Line 16: .getByName(getBookmark().getbookmark_name()) != null) {
Line 17: AddErrorMessages(
Line 18: VdcBllMessages.VAR__ACTION__ADD,
Line 19:
VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED);
You should also set the type variable in order for this to work.
Might be worth while moving these to setActionMessageParameters() while you're
at it.
Line 20: return false;
Line 21: }
Line 22:
Line 23: return true;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java
Line 22: boolean returnValue = true;
Line 23: if (getRoleDao().getByName(getRoleName()) != null) {
Line 24: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
Line 25: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__ROLE);
Line 26:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED);
Might be worth while moving these to setActionMessageParameters() while you're
at it.
Line 27: returnValue = false;
Line 28:
Line 29: }
Line 30: return returnValue;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java
Line 44: }
Line 45: if (getRoleDao().getByName(getRoleName()) != null) {
Line 46: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
Line 47: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__ROLE);
Line 48:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED);
Might be worth while moving these to setActionMessageParameters() while you're
at it.
Line 49: return false;
Line 50: }
Line 51: RoleType roleType = getRole().getType();
Line 52: if (roleType == null) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateComputerAccountCommand.java
Line 52: getActualPassword(),
Line 53: getComputerName()))
Line 54: .getReturnValue()).booleanValue();
Line 55: if (returnValue) {
Line 56:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED);
You should set ${type} and ${action} for this to work.
Might be worth while moving these to setActionMessageParameters() while you're
at it.
Line 57: }
Line 58: } else {
Line 59: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__CREATE);
Line 60:
addCanDoActionMessage(VdcBllMessages.VAR__TYPE__COMPUTER_ACCOUNT);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java
Line 28: if (!(current == null || current.getbookmark_id().equals(
Line 29: updated.getbookmark_id()))) {
Line 30: AddErrorMessages(
Line 31: VdcBllMessages.VAR__ACTION__UPDATE,
Line 32:
VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED);
You should also set ${type} in order for this to work
Might be worth while moving these to setActionMessageParameters() while you're
at it.
Line 33: } else {
Line 34: result = true;
Line 35: }
Line 36: }
--
To view, visit http://gerrit.ovirt.org/13063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbe8d4c2cc2510bba7aab1f4b760fb77528a118d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
