Laszlo Hornyak has posted comments on this change. Change subject: engine: use autoclose to clean up vdsdeploy ......................................................................
Patch Set 1: Hi all, If you look into let's say the class hierarchy of FileInputStream, you will see that it does not have a finalize method. There is no finalize method in any of the Reader's Writer's and all that, however not closing these resources correctly leads to running out of file handles. If you disagree, I am still open for a public discussion of the issue, let's put it on vote and let the community decide. -- To view, visit http://gerrit.ovirt.org/13090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43338f9d2d5bfb36c220f1fd19810f8c7436a543 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
