Tomas Jelinek has posted comments on this change.

Change subject: frontend: keep timezone as null on edit VM
......................................................................


Patch Set 2:

Is null a valid value for time zone? If yes, wouldn't it be better to let the 
user pick it all the time? Something like "No Timezone" in the combo box? 
Or, if the null is not a valid value, how is it possible that the user had it 
selected?
This fix seems to me a bit hacky - the FE does not let you to select null 
timezone, but if you managed to do it in some different way, than we will 
provide an emtpy value in the combo box.

--
To view, visit http://gerrit.ovirt.org/13197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f8c80ae783e88740ee907d9ff52c0bd6c40734c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to