Gilad Chaplik has uploaded a new change for review. Change subject: core: vdsSelector: remove method used once (12/15) ......................................................................
core: vdsSelector: remove method used once (12/15) I want to reduce method count, all methods names sounds the same to me. method removed: canFindAnyVds Change-Id: Ie05b7dfd98f9cd26e9158cd0ce7c2a958cd6bc8d Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/13214/1 diff --git a/backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java b/backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java index e41677f..a680a86 100644 --- a/backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java +++ b/backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java @@ -96,7 +96,8 @@ return false; } - returnValue = canFindAnyVds(messages, isMigrate); + returnValue = canFindVdsToRun(messages, isMigrate, + DbFacade.getInstance().getVdsDao().getAllOfTypes(new VDSType[] { VDSType.VDS, VDSType.oVirtNode })); } return returnValue; @@ -106,11 +107,6 @@ return getVdsToRunOn(DbFacade.getInstance() .getVdsDao() .getAllOfTypes(new VDSType[] { VDSType.VDS, VDSType.oVirtNode }), isMigrate); - } - - private boolean canFindAnyVds(List<String> messages, boolean isMigrate) { - return canFindVdsToRun(messages, isMigrate, - DbFacade.getInstance().getVdsDao().getAllOfTypes(new VDSType[] { VDSType.VDS, VDSType.oVirtNode })); } /** -- To view, visit http://gerrit.ovirt.org/13214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie05b7dfd98f9cd26e9158cd0ce7c2a958cd6bc8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
