Arik Hadas has posted comments on this change.

Change subject: userportal: introduce UserPortalRunOnceModel
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
Line 484: 
Line 485:         setIsCustomPropertiesSheetVisible(true);
Line 486:     }
Line 487: 
Line 488:     public abstract void init();
UserPortalListModel and VmListModel. I didn't want this method, but the 
simplest way to make the initialization is in such method as the initialization 
should be after the listeners were registered to the model.
Line 489: 
Line 490:     @Override
Line 491:     public void eventRaised(Event ev, Object sender, EventArgs args)
Line 492:     {


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java
Line 3: public class WebadminRunOnceModel extends RunOnceModel {
Line 4: 
Line 5:     @Override
Line 6:     public void init() {
Line 7: 
Of course, I'm working on it and it will be pushed as a separate patch (maybe 
it was a mistake not to push all the relevant patches together..)
Line 8:     }


--
To view, visit http://gerrit.ovirt.org/13207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6561df71f093e2739e689722ead4f85428c04d06
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to