Maor Lipchuk has uploaded a new change for review. Change subject: core: Snapshot failure should not be retried. ......................................................................
core: Snapshot failure should not be retried. When snapshot VDS command throw any exception, engine should end the command with an appropriate audit log which indicates that restart is required, instead retry the VDS command every 10 seconds and flood the event log. Change-Id: I8f56b025e0c6bbd9c9992ee65007a19c97658790 Signed-off-by: Maor Lipchuk <[email protected]> Bug-Url: https://bugzilla.redhat.com/923366 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/13262/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java index 76aa476..7aecbb3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java @@ -32,7 +32,6 @@ import org.ovirt.engine.core.common.config.Config; import org.ovirt.engine.core.common.config.ConfigValues; import org.ovirt.engine.core.common.errors.VdcBLLException; -import org.ovirt.engine.core.common.errors.VdcBllErrors; import org.ovirt.engine.core.common.utils.Pair; import org.ovirt.engine.core.common.validation.group.CreateEntity; import org.ovirt.engine.core.common.vdscommands.SnapshotVDSCommandParameters; @@ -231,9 +230,6 @@ } }); } catch (VdcBLLException e) { - if (e.getErrorCode() != VdcBllErrors.SNAPSHOT_FAILED) { - throw e; - } handleVdsLiveSnapshotFailure(e); } } -- To view, visit http://gerrit.ovirt.org/13262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8f56b025e0c6bbd9c9992ee65007a19c97658790 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
