Alon Bar-Lev has posted comments on this change.

Change subject: Do not raise an Exception processing stdout/err
......................................................................


Patch Set 1:

Thanks!

Maybe like other unicode methods we should replace all non unicode characters 
with '?', and continue as usual, instead of dropping entire lines.

I think that for x in y also should not be used if y is non unicode, no?

--
To view, visit http://gerrit.ovirt.org/13277
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I121d975083f02957aad927305d2cd9157c77b3ea
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to