Yair Zaslavsky has uploaded a new change for review. Change subject: core: Removing unused PollTask method ......................................................................
core: Removing unused PollTask method Change-Id: I65add68f12fc09e837a4298dfc95c6a505c95055 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java 1 file changed, 0 insertions(+), 63 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/13292/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java index 75ee506..55259c7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java @@ -370,69 +370,6 @@ } } - protected AsyncTaskStatus PollTask() { - AsyncTaskStatus returnValue = null; - - try { - Object tempVar = Backend - .getInstance() - .getResourceManager() - .RunVdsCommand(VDSCommandType.SPMGetTaskStatus, - new SPMTaskGuidBaseVDSCommandParameters(getStoragePoolID(), getTaskID())).getReturnValue(); - returnValue = (AsyncTaskStatus) ((tempVar instanceof AsyncTaskStatus) ? tempVar : null); - } - - catch (RuntimeException e) { - log.error( - String.format( - "SPMAsyncTask::PollTask: Polling task '%1$s' (Parent Command %2$s, Parameters Type %3$s) threw an exception, task is still considered running.", - getTaskID(), - (getParameters().getDbAsyncTask().getaction_type()), - getParameters().getClass().getName()), - e); - } - - if (returnValue == null) { - log.errorFormat( - "SPMAsyncTask::PollTask: Polling task '{0}' (Parent Command {1}, Parameters Type {2}) failed, task is still considered running.", - getTaskID(), - (getParameters().getDbAsyncTask().getaction_type()), - getParameters() - .getClass().getName()); - - AsyncTaskStatus tempVar2 = new AsyncTaskStatus(); - tempVar2.setStatus(AsyncTaskStatusEnum.running); - returnValue = tempVar2; - } - - String formatString = - "SPMAsyncTask::PollTask: Polling task '{0}' (Parent Command {1}, Parameters Type {2}) returned status '{3}'{4}."; - - if (returnValue.getTaskIsInUnusualState()) { - log.warnFormat( - formatString, - getTaskID(), - (getParameters().getDbAsyncTask().getaction_type()), - getParameters().getClass().getName(), - returnValue.getStatus(), - ((returnValue.getStatus() == AsyncTaskStatusEnum.finished) ? (String.format(", result '%1$s'", - returnValue.getResult())) : (""))); - } - - else { - log.infoFormat( - formatString, - getTaskID(), - (getParameters().getDbAsyncTask().getaction_type()), - getParameters().getClass().getName(), - returnValue.getStatus(), - ((returnValue.getStatus() == AsyncTaskStatusEnum.finished) ? (String.format(", result '%1$s'", - returnValue.getResult())) : (""))); - } - - return returnValue; - } - public void stopTask() { stopTask(false); } -- To view, visit http://gerrit.ovirt.org/13292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I65add68f12fc09e837a4298dfc95c6a505c95055 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
