Daniel Erez has posted comments on this change.

Change subject: core: update DiskImageDynamic on RemoveSnapshot
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
Line 83:             
getDestinationDiskImage().setVolumeType(curr.getVolumeType());
Line 84:             
getDestinationDiskImage().setParentId(getDiskImage().getParentId());
Line 85:             getBaseDiskDao().update(curr);
Line 86:             getImageDao().update(getDestinationDiskImage().getImage());
Line 87:             updateDiskImageDynamic();
it's called on endSuccessfully()
Line 88:         }
Line 89: 
Line 90:         setSucceeded(true);
Line 91:     }


--
To view, visit http://gerrit.ovirt.org/13243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie124fb42c34860ee349e91172e0248a2d824b127
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to