Juan Hernandez has posted comments on this change.

Change subject: packaging: less intrusive method for httpd integration
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File packaging/fedora/setup/ovirt-engine-proxy.conf.in
Line 15: #
Line 16: # This is needed to make sure that long RESTAPI requests have time to
Line 17: # finish before the web server aborts the request as the default 
timeout
Line 18: # (controlled by the Timeout directive in httpd.conf) is 60 seconds.
Line 19: #
This comment is now misplaced.

Instead of repeating the configuration parameters (retry, timeout, etc) create 
a proxy configuration:

  <Proxy ajp://localhost:@JBOSS_AJP_PORT@>
    # This is needed to make sure that connections to the application server
    # are recovered in a short time interval (5 seconds at the moment)
    # otherwise when the application server is restarted the web server will
    # refuse to connect during 60 seconds.
    ProxySet retry=5

    # This is needed to make sure that long RESTAPI requests have time to
    # finish before the web server aborts the request as the default timeout
    # (controlled by the Timeout directive in httpd.conf is 60 seconds).
    ProxySet timeout=3600
  </Proxy>

Then just use it, without the parameters:

  ProxyPass /... ajp://locahost@JBOSS_AJP_PORT@/...
Line 20: 
Line 21: Redirect /ovirt-engine /ovirt-engine/
Line 22: ProxyPass /ovirt-engine/ ajp://localhost:@JBOSS_AJP_PORT@/ retry=5 
timeout=3600
Line 23: 


Line 20: 
Line 21: Redirect /ovirt-engine /ovirt-engine/
Line 22: ProxyPass /ovirt-engine/ ajp://localhost:@JBOSS_AJP_PORT@/ retry=5 
timeout=3600
Line 23: 
Line 24: <LocationMatch 
^/(UserPortal|OvirtEngineWeb|Components|webadmin|ca.crt|engine.ssh.key.txt|rhevm.ssh.key.txt|docs|spice|ovirt-engine.html|404.html)>
We don't use any URL starting with "Components".
Line 25:        ProxyPassMatch ajp://localhost:@JBOSS_AJP_PORT@ retry=5 
timeout=3600
Line 26: </LocationMatch>
Line 27: 
Line 28: #


--
To view, visit http://gerrit.ovirt.org/13318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to