Liron Ar has posted comments on this change.

Change subject: core: export vm/create template shouldn't include ILLEGAL disks
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 623:         }
Line 624:         return validationResult.isValid();
Line 625:     }
Line 626: 
Line 627:     private static boolean checkImagesLegalityInVdsm
if anyone has better name to suggest, I'd be happy to hear.
Line 628:             (List<String> messages, List<DiskImage> images, 
List<DiskImage> irsImages) {
Line 629:         boolean returnValue = true;
Line 630:         int i = 0;
Line 631:         for (DiskImage diskImage : images) {


--
To view, visit http://gerrit.ovirt.org/13203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e608c0c87c6e3a8d275fd74658b888cde6c8694
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to