Sandro Bonazzola has posted comments on this change. Change subject: core: Locate data source in a loop ......................................................................
Patch Set 7: I would prefer that you didn't submit this in patch set 7 you've defined: privatestaticvolatileDbFacadedbFacade; Then in getDbFacade() you assign dbFacadewith the result of the synchronized call to createDbFacade. But in createDbFacade you already assign dbFacade: dbFacade =newDbFacade(); So it seems you'll have dbFacade assigned in an earlier stage, when it's not fully configured. -- To view, visit http://gerrit.ovirt.org/10189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72c99c61d05e8a1619c7d1fb70af956d1050eb3a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
