Tal Nisan has posted comments on this change. Change subject: core: doesStorageDomainHaveSpaceForRequest(long) ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) Comment on the commit message subject, up to you .................................................... Commit Message Line 3: AuthorDate: 2013-03-25 13:06:10 +0200 Line 4: Commit: Allon Mureinik <[email protected]> Line 5: CommitDate: 2013-03-25 13:06:10 +0200 Line 6: Line 7: core: doesStorageDomainHaveSpaceForRequest(long) Subject is a bit obscure, why not change it to Remove unused method from MoveOrCopyDiskCommand? Line 8: Line 9: Removed Line 10: MoreOrCopyDiskCommand..doesStorageDomainHaveSpaceForRequest(long), which Line 11: is not used anywhere in the code. -- To view, visit http://gerrit.ovirt.org/13324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12e0ed58810bf87342cc06db4b7cec4c527b6ff5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
