Einav Cohen has posted comments on this change. Change subject: core: Remove unused GetVmsByVmTemplateGuidQuery ......................................................................
Patch Set 2: > We might want to use this query for the sub-tab as search is limited for 100 > results by default (instead of the search-query according to the template > name). indeed, using the query will not be limited in results quantity (like the search). However, I think that the results-quantity limitation is actually desirable here, assuming we will potentially have performance issues if results will contain a very large number of items, and assuming that we will introduce paging to the sub-tabs at some point. So I think it is OK that the search will remain as the "source" of the sub-tab contents (I am not thrilled about the fact that we are searching according to Name rather than ID, but that's a different story and a material for a separate patch...), so IMO we can safely proceed with this patch for removing the GetVmsByVmTemplateGuid query. -- To view, visit http://gerrit.ovirt.org/13281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieef493712c75bc386dce066f9774ffe83c1be8fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
