Gilad Chaplik has posted comments on this change.
Change subject: core: vdsSelector: remove method used once (10/15)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/sla/src/main/java/org/ovirt/engine/core/sla/VdsSelector.java
Line 58: }
Line 59:
Line 60: public Guid getVdsToRunOn(boolean isMigrate) {
Line 61: Guid result = Guid.Empty;
Line 62: if (getDestinationVdsId() != null) {
*
Line 63: VDS target_vds =
DbFacade.getInstance().getVdsDao().get(getDestinationVdsId());
Line 64: log.infoFormat("Checking for a specific VDS only - id:{0},
name:{1}, host_name(ip):{2}",
Line 65: getDestinationVdsId(), target_vds.getName(),
target_vds.getHostName());
Line 66: result = getVdsToRunOn(new
ArrayList<VDS>(Arrays.asList(new VDS[] { target_vds })), isMigrate);
Line 101
Line 102
Line 103
Line 104
Line 105
it's not safe but... look at *
:-)
the nullity check here is redundant
--
To view, visit http://gerrit.ovirt.org/13212
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecedcd6b9b754dbd853304d58083a556dab51cfa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
