Michael Kublin has uploaded a new change for review. Change subject: engine: Clean unused method ......................................................................
engine: Clean unused method The following method is not in use, so removed Change-Id: I82d7ae999a38c4ec9690192e4e26d09bf0f5343f Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java 2 files changed, 0 insertions(+), 25 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/13424/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java index 17822db..981f2da 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java @@ -32,20 +32,6 @@ return returnValue; } - public static PropertyInfo GetProperty(Class<?> type, String idField) { - try { - PropertyDescriptor[] pds = Introspector.getBeanInfo(type).getPropertyDescriptors(); - for (PropertyDescriptor pd : pds) { - if (pd.getName().equalsIgnoreCase(idField)) { - return new PropertyInfo(pd); - } - } - } catch (Exception e) { - throw new RuntimeException(e); - } - return null; - } - /** * The following method will get values for properties of provided object and will keep them in map * @param obj - this is an object which values will be taken diff --git a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java index 7b80fd3..990374e 100644 --- a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java +++ b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java @@ -10,21 +10,10 @@ import java.util.Set; import org.junit.Test; -import org.ovirt.engine.core.compat.backendcompat.PropertyInfo; import org.ovirt.engine.core.compat.backendcompat.TypeCompat; public class PropertyInfoTest { private String someValue = "Anakin"; - - @Test - public void testIt() { - PropertyInfo propInfo = TypeCompat.GetProperty(this.getClass(), "someValue"); - String result = (String) propInfo.getValue(this, "JarJar"); - assertEquals("Standard", "Anakin", result); - this.someValue = null; - result = (String) propInfo.getValue(this, "JarJar"); - assertEquals("Null Value", "JarJar", result); - } @Test public void testGetAvailableValues() { -- To view, visit http://gerrit.ovirt.org/13424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I82d7ae999a38c4ec9690192e4e26d09bf0f5343f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
