Allon Mureinik has posted comments on this change.

Change subject: core, ui: Generic way to check double names
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsEntityWithSameNameExistsParameters.java
Line 4: 
Line 5: public class IsEntityWithSameNameExistsParameters extends 
VdcQueryParametersBase {
Line 6:     private static final long serialVersionUID = -6382046704879479790L;
Line 7: 
Line 8:     public IsEntityWithSameNameExistsParameters() {
This isn't done in any other parameters class, so I want to keep suite.
Line 9:     }
Line 10: 
Line 11:     public IsEntityWithSameNameExistsParameters(String name, 
VdcObjectType type) {
Line 12:         this.name = name;


Line 8:     public IsEntityWithSameNameExistsParameters() {
Line 9:     }
Line 10: 
Line 11:     public IsEntityWithSameNameExistsParameters(String name, 
VdcObjectType type) {
Line 12:         this.name = name;
This isn't done in any other parameters class, so I want to keep suite.
Line 13:         this.type = type;
Line 14:     }
Line 15: 
Line 16:     private String name;


--
To view, visit http://gerrit.ovirt.org/13338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I621c963110c8979b461b04502b3aab2455faf5b6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to