Maor Lipchuk has posted comments on this change.
Change subject: core: log stacktraces for failed VDSCommandBase calls
......................................................................
Patch Set 2: No score
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
Line 112: }
Line 113:
Line 114: private void logException(VDSExceptionBase ex) {
Line 115: log.errorFormat("Command {0} execution failed with an
unexpected exception:", getCommandName());
Line 116: log.error(ExceptionUtils.getStackTrace(ex));
I think that it will be better to put the stack trace in debug mode.
I'm afraid it will create unneccessery noise in the logs.
Alternatively you can use getMessage which is more cleaner.
Line 117: }
Line 118:
Line 119: private void logException(RuntimeException ex) {
Line 120: log.errorFormat("Command {0} execution failed. Exception:
{1}", getCommandName(), ExceptionUtils.getMessage(ex));
--
To view, visit http://gerrit.ovirt.org/8243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d03f42a061531757daf870a6ac8eed34c2f992
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
