Hello Alon Bar-Lev,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/13459
to review the following change.
Change subject: build: use embedded gettext
......................................................................
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it externally
Change-Id: Iedf5d59e18c82c792258d03fdef6bf14fb28c4f2
Signed-off-by: Alon Bar-Lev <[email protected]>
---
M .gitignore
M Makefile.am
M configure.ac
M ovirt-iso-uploader.spec.in
4 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-iso-uploader
refs/changes/59/13459/1
diff --git a/.gitignore b/.gitignore
index 5c336bf..80b19ea 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,6 +14,8 @@
config.sub
ABOUT-NLS
+intl
+
tmp.*
*.pyc
*.pyo
diff --git a/Makefile.am b/Makefile.am
index 22e1970..fa0c9a4 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -37,6 +37,7 @@
$(NULL)
SUBDIRS = \
+ intl \
po \
src \
$(NULL)
diff --git a/configure.ac b/configure.ac
index bc98c27..61ccb3f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -35,7 +35,7 @@
AC_USE_SYSTEM_EXTENSIONS
AM_INIT_AUTOMAKE
AM_GNU_GETTEXT_VERSION([0.17])
-AM_GNU_GETTEXT([external])
+AM_GNU_GETTEXT
AC_ARG_ENABLE(
[python-syntax-check],
@@ -75,6 +75,7 @@
Makefile
ovirt-iso-uploader.spec
src/Makefile
+ intl/Makefile
po/Makefile.in
])
AC_OUTPUT
diff --git a/ovirt-iso-uploader.spec.in b/ovirt-iso-uploader.spec.in
index 8023e76..65c3dac 100644
--- a/ovirt-iso-uploader.spec.in
+++ b/ovirt-iso-uploader.spec.in
@@ -29,10 +29,8 @@
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}
BuildArch: noarch
-Requires: gettext
Requires: python
Requires: ovirt-engine-sdk
-BuildRequires: gettext-devel
BuildRequires: python2-devel
%description
--
To view, visit http://gerrit.ovirt.org/13459
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedf5d59e18c82c792258d03fdef6bf14fb28c4f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: ovirt-iso-uploader-3.2
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
